[ 
https://issues.apache.org/jira/browse/CALCITE-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benchao Li resolved CALCITE-5510.
---------------------------------
    Fix Version/s: 1.34.0
       Resolution: Fixed

Fixed via 
https://github.com/apache/calcite/commit/0e8d6b093d26c291361bfd63ecb14828d1e33bc6

[~peng713128] Thanks for reporting and the PR, and fast response!
Thanks [~ZouDan][~Chunwei Lei] [~julianhyde] for the review!

> RelToSqlConverter don't support sort by ordinal when sort by column is a 
> expression
> -----------------------------------------------------------------------------------
>
>                 Key: CALCITE-5510
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5510
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.26.0
>            Reporter: peng wang
>            Assignee: peng wang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.34.0
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> For example:
> Query SQL isĀ 
> {code:java}
> select a, sum(b) from table group by a order by 2{code}
> When we convert this sql to relNode and convert it back to SQL by 
> RelToConverter, the result is:
> {code:java}
> select a, sum(b) from table group by a order by sum(b){code}
> But we want to keep order by column to ordinal.
> Would we add a switch in RelToConverter to control whether convert sort by 
> column to expression or ordinal?
> Maybe we can use method isSortByOrdinal in dialect SqlConformance?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to