[
https://issues.apache.org/jira/browse/CALCITE-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691170#comment-17691170
]
Benchao Li edited comment on CALCITE-5510 at 2/20/23 1:12 PM:
--------------------------------------------------------------
Reopened, because this patch makes some slow tests fail:
https://github.com/apache/calcite/actions/runs/4223301074/jobs/7332876394
I've force-pushed the main branch to revert this change. [~peng713128] could
you help to fix these test failures?
was (Author: libenchao):
Reopened, because this patch makes some slow tests fail:
https://github.com/apache/calcite/actions/runs/4223301074/jobs/7332876394
> RelToSqlConverter should use ordinal for ORDER BY if the dialect allows
> -----------------------------------------------------------------------
>
> Key: CALCITE-5510
> URL: https://issues.apache.org/jira/browse/CALCITE-5510
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.26.0
> Reporter: peng wang
> Assignee: peng wang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.34.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> For example:
> Query SQL is
> {code:java}
> select a, sum(b) from table group by a order by 2{code}
> When we convert this sql to relNode and convert it back to SQL by
> RelToConverter, the result is:
> {code:java}
> select a, sum(b) from table group by a order by sum(b){code}
> But we want to keep order by column to ordinal.
> Would we add a switch in RelToConverter to control whether convert sort by
> column to expression or ordinal?
> Maybe we can use method isSortByOrdinal in dialect SqlConformance?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
