[
https://issues.apache.org/jira/browse/CALCITE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693090#comment-17693090
]
Julian Hyde commented on CALCITE-5357:
--------------------------------------
[~tjbanghart], I have reviewed your PR 3034 and it looks good. I have made some
further edits - fix a threading issue by introducing a ThreadLocal, enable the
relevant tests in big-query.iq, convert FormatModel into an interface, convert
FormatModels into a utility class, and use SqlBasicFunction instead of
SqlBigQueryFormatDatetimeFuncton - which you can see in
[julianhyde/2980-cast-format|https://github.com/julianhyde/calcite/tree/2980-cast-format].
If those changes look OK I'll squash, rebase, merge.
> Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE
> ------------------------------------------------
>
> Key: CALCITE-5357
> URL: https://issues.apache.org/jira/browse/CALCITE-5357
> Project: Calcite
> Issue Type: Sub-task
> Components: core
> Reporter: TJ Banghart
> Assignee: TJ Banghart
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
