[
https://issues.apache.org/jira/browse/CALCITE-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697136#comment-17697136
]
Julian Hyde commented on CALCITE-5554:
--------------------------------------
* Did you consider adding {{DAYOFWEEK}} and {{DAYOFYEAR}} as custom time
frames? If you had done that, no paser changes would have been required, and we
would probably have gotten {{DATEPART(DAYOFWEEK, ...)}} for free.
* Add a test to SqlOperatorTest
* The {{DAYOFWEEK}} and {{DAYOFYEAR}} functions exist but tests are disabled in
SqlOperatorTest. Can you check whether those tests now pass? If it's easy to
enable them, let's do that.
> Add DAYOFWEEK and DAYOFYEAR as valid synonyms of DOW, DOY
> ---------------------------------------------------------
>
> Key: CALCITE-5554
> URL: https://issues.apache.org/jira/browse/CALCITE-5554
> Project: Calcite
> Issue Type: Improvement
> Reporter: Tanner Clary
> Assignee: Tanner Clary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, a query such as: {{EXTRACT(DAYOFWEEK FROM DATE '2008-12-25');}} is
> invalid while {{EXTRACT(DOW FROM DATE '2008-12-25')}} is acceptable. BigQuery
> (and perhaps other dialects) accept the non-abbreviated version as a valid
> time unit. After this change, DAYOFWEEK and DAYOFYEAR would both be synonyms
> of DOW and DOY, respectively.
> [Relevant BigQuery
> Docs|https://cloud.google.com/bigquery/docs/reference/standard-sql/date_functions#extract]
> Any comments, questions, or suggestions for the linked PR are highly
> appreciated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
