[
https://issues.apache.org/jira/browse/CALCITE-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17699880#comment-17699880
]
Stamatis Zampetakis commented on CALCITE-5575:
----------------------------------------------
[~tanclary] [~julianhyde] Out of curiosity why did the changes for CALCITE-5469
etc went in the core parser and not in the babel? In the past (CALCITE-3218),
for similar non-standard functions we opted for babel.
> Incorrect priority of builtinFunctionCallMethods in Parser.jj
> -------------------------------------------------------------
>
> Key: CALCITE-5575
> URL: https://issues.apache.org/jira/browse/CALCITE-5575
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.34.0
> Reporter: James Turton
> Priority: Major
>
> CALCITE-5469 and others have introduced new date and time functions. In
> Parser.jj (line 6152) these new functions are handled _above_ the
> builtinFunctionCallMethods Freemarker loop that allows applications to add
> their own function defintions.
> {code:java}
> node = DateTimeConstructorCall() { return node; }
> |
> node = DateDiffFunctionCall() { return node; }
> |
> node = DateTruncFunctionCall() { return node; }
> |
> node = TimestampAddFunctionCall() { return node; }
> |
> node = DatetimeDiffFunctionCall() { return node; }
> |
> node = TimestampDiffFunctionCall() { return node; }
> |
> node = TimestampDiff3FunctionCall() { return node; }
> |
> node = TimestampTruncFunctionCall() { return node; }
> |
> node = TimeDiffFunctionCall() { return node; }
> |
> node = TimeTruncFunctionCall() { return node; }
> |
> <#list
> (parser.builtinFunctionCallMethods!default.parser.builtinFunctionCallMethods)
> as method>
> node = ${method} { return node; }
> |
> </#list>{code}
> This means (I think) that applications are effectively unable to override the
> new date and time function definitions with their own definitions. In
> particular, Drill cannot override the new three-parameter DATE_DIFF function
> in order to provide the parser method needed by its own two-parameter
> DATE_DIFF function resulting in a regression in the form of a broken
> DATE_DIFF function.
> If the above is correct then can the builtinFunctionCallMethods Freemarker
> loop move above these date and time functions? Could it even move above the
> special syntax functions higher up, for that matter?
> Incidentally I also noted in Parser.jj that the new date and time functions
> mentioned above are also handled seperately in JdbcFunctionCall which
> implements JDBC function call syntax. This makes me unsure whether
> application overrides provided in builtinFunctionCallMethods will take
> priority over these Calcite definitions when they are invoked with JDBC
> syntax.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
