[
https://issues.apache.org/jira/browse/CALCITE-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stamatis Zampetakis resolved CALCITE-5571.
------------------------------------------
Fix Version/s: 1.35.0
Resolution: Fixed
Fixed in
[https://github.com/apache/calcite/commit/12b7193e4f005e72aee27290bf71f72badd5e7da.]
Thanks for the reviews [~snuyanzin] [~libenchao] [~ZouDan] !
> Remove org.jetbrains.annotations from java source code
> ------------------------------------------------------
>
> Key: CALCITE-5571
> URL: https://issues.apache.org/jira/browse/CALCITE-5571
> Project: Calcite
> Issue Type: Task
> Affects Versions: 1.33.0
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.35.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In the most part we are using checkerframework annotations
> (org.checkerframework.checker.nullness.qual) for specifying nullability.
> There are 2 places, namely {{ScannableTableTest}} and {{UtilTest}} where we
> have nullability annotations from org.jetbrains.annotations package.
> To keep things consistent and also avoid mixing up annotations from different
> providers in the future, I propose to remove the last references to
> org.jetbrains.annotations and exclude the org.jetbrains:annotations
> dependency from the build to avoid accidentally using such annotations in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
