[
https://issues.apache.org/jira/browse/CALCITE-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700987#comment-17700987
]
Julian Hyde commented on CALCITE-5574:
--------------------------------------
I reviewed. Looks good. Nice work.
> Break MockCatalogReaderSimple#init into smaller methods
> -------------------------------------------------------
>
> Key: CALCITE-5574
> URL: https://issues.apache.org/jira/browse/CALCITE-5574
> Project: Calcite
> Issue Type: Improvement
> Components: tests
> Reporter: Benchao Li
> Assignee: Zou
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In the
> [discussion|https://github.com/apache/calcite/pull/3092#discussion_r1131364712]
> of https://github.com/apache/calcite/pull/3092,
> {{MockCatalogReaderSimple#init}} is too long to add new code, we should break
> it into smaller ones. One possible way is to move each table registration to
> a separate one method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
