[
https://issues.apache.org/jira/browse/CALCITE-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ran Tao updated CALCITE-5623:
-----------------------------
Description:
The code of many calcite modules use the 'assert' keyword of java to do
checking, which actually depends on the enablement of the -enableassertions
(-ea) option (default is false, which means some assert code can not work),
otherwise it may lead to unexpected behavior and cause NPE.
In fact, we have some mature Preconditions tools, we can use it to replace
'assert' keyword.
why calcite project use 'assert' keyword frequently? or it's a technical debt?
was:
The code of many calcite modules use the 'assert' keyword of java to do
checking, which actually depends on the enablement of the -enableassertions
(-ea) option (default is false, which means some assert code can not work),
otherwise it may lead to unexpected behavior and cause NPE.
In fact, we have some mature Preconditions tool, we can use it to replace
'assert' keyword.
why calcite project use 'assert' keyword frequently? or it's a technical debt?
> calcite assert keyword usage
> ----------------------------
>
> Key: CALCITE-5623
> URL: https://issues.apache.org/jira/browse/CALCITE-5623
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.34.0
> Reporter: Ran Tao
> Assignee: Ran Tao
> Priority: Major
>
> The code of many calcite modules use the 'assert' keyword of java to do
> checking, which actually depends on the enablement of the -enableassertions
> (-ea) option (default is false, which means some assert code can not work),
> otherwise it may lead to unexpected behavior and cause NPE.
> In fact, we have some mature Preconditions tools, we can use it to replace
> 'assert' keyword.
> why calcite project use 'assert' keyword frequently? or it's a technical debt?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
