[ 
https://issues.apache.org/jira/browse/CALCITE-5647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Kennedy updated CALCITE-5647:
----------------------------------
    Description: 
A few locations in Calcite call rel.estimateRowCount(mq) when they should 
instead call mq.getRowCount(red).

We detected this because we implemented row count estimation entirely within an 
alternative handle instead of RelMdRowCount, and then override estimateRowCount 
to ensure the custom handler is user, by throwing an unreachable code exception.

A few places in Calcite trigger these unreachable exceptions because they do 
not use mq.getRowCount.

The most easily triggered on is in RelMdPopulationSize for the Values parameter.

  was:
A few locations in Calcite call rel.estimateRowCount(mq) when they should 
instead call mq.getRowCount(red).

We detected this because we implemented row count estimation entirely within an 
alternative handle instead of RelMdRowCount, and then override estimateRowCount 
to ensure the custom handler is user, by throwing an unreachable code exception.

A few places in Calcite trigger these unreachable exceptions because they do 
not use mq.getRowCount.


> RelMdPopulationSize calls rel.estimateRowCount instead of mq.getRowCount
> ------------------------------------------------------------------------
>
>                 Key: CALCITE-5647
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5647
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.34.0
>            Reporter: Adam Kennedy
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> A few locations in Calcite call rel.estimateRowCount(mq) when they should 
> instead call mq.getRowCount(red).
> We detected this because we implemented row count estimation entirely within 
> an alternative handle instead of RelMdRowCount, and then override 
> estimateRowCount to ensure the custom handler is user, by throwing an 
> unreachable code exception.
> A few places in Calcite trigger these unreachable exceptions because they do 
> not use mq.getRowCount.
> The most easily triggered on is in RelMdPopulationSize for the Values 
> parameter.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to