[
https://issues.apache.org/jira/browse/CALCITE-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714344#comment-17714344
]
Julian Hyde commented on CALCITE-5611:
--------------------------------------
Looks good.
Do you think there would be any benefit to some or all of the arguments being
{{Supplier<String>}} rather than {{String}}? Maybe it would reduce the
profusion of {{"Query: " + sql}} arguments.
I'll leave it up to you. LGTM as is.
> Show SQL query for failed tests for SqlOperatorTest
> ---------------------------------------------------
>
> Key: CALCITE-5611
> URL: https://issues.apache.org/jira/browse/CALCITE-5611
> Project: Calcite
> Issue Type: Improvement
> Components: tests
> Affects Versions: 1.34.0
> Reporter: Sergey Nuyanzin
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The issue is that there are lots of cases under each test in
> {{SqlOperatorTest}} and it is not clear which of them is failing.
> The idea is to print sql query from the test if it's failed besides
> type/result comparison
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
