[ 
https://issues.apache.org/jira/browse/CALCITE-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719061#comment-17719061
 ] 

Julian Hyde commented on CALCITE-5610:
--------------------------------------

[~tanclary], It looks good. Can you rebase your PR, and move your functions 
into the ALL library, as CALCITE-5606 did for TANH etc. Also add brief javadoc 
for each field you added to {{{}SqlLibraryOperators{}}}. Then I'll merge.

> Implement COTH, CSCH, SECH Functions
> ------------------------------------
>
>                 Key: CALCITE-5610
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5610
>             Project: Calcite
>          Issue Type: Sub-task
>            Reporter: Tanner Clary
>            Assignee: Tanner Clary
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> * {{COTH(X)}}: Computes the hyperbolic cotangent for the angle of {{X}}, 
> where {{X}} is specified in radians. 
> [Docs|https://cloud.google.com/bigquery/docs/reference/standard-sql/mathematical_functions#coth]
> * {{CSCH(X)}}: Computes the hyperbolic cosecant for the angle of {{X}}, where 
> {{X}} is specified in radians. 
> [Docs|https://cloud.google.com/bigquery/docs/reference/standard-sql/mathematical_functions#csch]
> * {{SECH(X)}}: Computes the hyperbolic secant for the angle of {{X}}, where 
> {{X}} is specified in radians. 
> [Docs|https://cloud.google.com/bigquery/docs/reference/standard-sql/mathematical_functions#sech]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to