[
https://issues.apache.org/jira/browse/CALCITE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726315#comment-17726315
]
Ian Bertolacci commented on CALCITE-5722:
-----------------------------------------
[~libenchao] Thanks!
[~julianhyde] I was able to come up with an expression that exhibits this issue.
If you construct {{`a not in (1.0, 2.0, 3.0)`}} as {{`not ( a < 1.0 or (1.0 < a
and a < 2.0) or 2.00 < a )`}} (notice the extra 0 in {{{}`2.00`{}}}) and then
apply simplification, you get the Sarg literal: {{{}`Sarg[1.0:DECIMAL(3, 2),
[2.0:DECIMAL(3, 2)..2.00:DECIMAL(3, 2)] ]:DECIMAL(3, 2)`{}}}, for which
{{`.isPoints`}} returns false (because BigDecimal(2.0) != BigDecimal(2.00)).
I will add a RexProgramTest for this.
> Sarg.isComplementedPoints fails with anti-points which are equal under
> `compareTo` but not `equals`
> ---------------------------------------------------------------------------------------------------
>
> Key: CALCITE-5722
> URL: https://issues.apache.org/jira/browse/CALCITE-5722
> Project: Calcite
> Issue Type: Bug
> Affects Versions: 1.34.0
> Reporter: Ian Bertolacci
> Assignee: Ian Bertolacci
> Priority: Minor
>
> Example:
> {code:java}
> final Sarg<BigDecimal> badComplimentPointsSarg =
> Sarg.of(
> RexUnknownAs.UNKNOWN,
> TreeRangeSet.create(
> Arrays.asList(
> // Create anti-point around 1, with different scales
> Range.lessThan(new BigDecimal("1")),
> Range.greaterThan(new BigDecimal("1.00000000000"))
> )
> )
> );
> assertThat(badComplimentPointsSarg.isComplementedPoints(), is(true));
> {code}
> will fail.
> This is because [RangeSets.isPoints uses direct equality and not
> `Comparable.compareTo`
> equality|https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/util/RangeSets.java#LL132C1-L133C1]
> The values {{`1`}} and {{`1.00000000000`}} are not equal under
> `BigDecimal.equals` but are equal under `BigDecimal.compareTo`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
