[
https://issues.apache.org/jira/browse/CALCITE-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benchao Li resolved CALCITE-5759.
---------------------------------
Fix Version/s: 1.35.0
Resolution: Fixed
Fixed via
https://github.com/apache/calcite/commit/10f1744709cc7d897651314c03b69f8e4b959bce
[~Runking] Thanks for your contribution! And [~nobigo] thanks for the review!
> 'SEARCH(1, Sarg[IS NOT NULL])' should be simplified to 'TRUE'
> -------------------------------------------------------------
>
> Key: CALCITE-5759
> URL: https://issues.apache.org/jira/browse/CALCITE-5759
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.34.0
> Reporter: Runkang He
> Assignee: Runkang He
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.35.0
>
>
> The minimal reproducer is to construct a RexCall with RexUnknownAs.FALSE as
> below:
> {code:sql}
> SEARCH(1, Sarg[IS NOT NULL])
> {code}
> After RexSimplify#simplifySearch, the final simplified result is IS NOT
> NULL(1), which should be TRUE more thoroughly.
> Also, the following RexCall with RexUnknownAs.TRUE:
> {code:sql}
> SEARCH(1, Sarg[IS NULL])
> {code}
> Is simplified to IS NULL(1), which should be FALSE.
> Another two cases:
> The following RexCall with RexUnknownAs.UNKNOWN:
> {code:sql}
> SEARCH(1, Sarg[=])
> {code}
> Is simplified to 1 IS NOT NULL OR NULL, which should be TRUE.
> The following RexCall with RexUnknownAs.UNKNOWN:
> {code:sql}
> SEARCH(1, Sarg[<>])
> {code}
> Is simplified to 1 <> 1, which should be FALSE.
> Note that current simplified result is inconsistent with
> RexCall.isAlwaysFalse and isAlwaysTrue.
> Therefore, for the above two reasons, I think we need to simplify SEARCH
> operator with special sarg more thoroughly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
