[
https://issues.apache.org/jira/browse/CALCITE-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734144#comment-17734144
]
Runkang He commented on CALCITE-5780:
-------------------------------------
[~nobigo] Thanks for your advice. I have changed the title to make it clear.
And add three tests to cover the case in second advice.
Besides, for code change in `isEffectivelyNotNull` for reverse order
comparison, I think we could split this part of code to another Jira, and it
will be more clear why makes these changes. And I will add more specific tests
for this code change. Looking forward to your suggestion.
> Simplify '1 > x OR 1 <= x OR x IS NULL' to TRUE
> -----------------------------------------------
>
> Key: CALCITE-5780
> URL: https://issues.apache.org/jira/browse/CALCITE-5780
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.34.0
> Reporter: Runkang He
> Assignee: Runkang He
> Priority: Major
> Labels: pull-request-available
>
> The following expressions which contain reverse order comparison are always
> true:
> {code:sql}
> 1 > x or 1 <= x or x is null
> 1 < x or 1 >= x or x is null
> 1 > x or 0 < x or x is null
> {code}
> But currently these expressions are not fully simplified to TRUE, the current
> simplified results are SEARCH operator.
> The root cause is that RexSimplify doesn't identify these cases and makes
> targeted simplification.
> It would be nice if RexSimplify.simplifyOr handled these cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
