[ 
https://issues.apache.org/jira/browse/CALCITE-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738282#comment-17738282
 ] 

Ruben Q L commented on CALCITE-5686:
------------------------------------

Thanks [~julianhyde] for checking this. I know that [~thomas.rebele] is on 
vacation these days, so probably we will not have a PR soon. In any case, I'm 
aware that this is not a high priority for him any more, so I'm reducing the 
priority of the ticket (anyway, I agree that it would be nice to have it for 
1.36).

> Generalize return types of the linq4j expression shuttle
> --------------------------------------------------------
>
>                 Key: CALCITE-5686
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5686
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Thomas Rebele
>            Assignee: Thomas Rebele
>            Priority: Major
>
> The following block in org.apache.calcite.linq4j.tree.Shuttle prevents 
> replacing constants with other expressions:
> {code:java}
>   public ConstantExpression visit(ConstantExpression constantExpression) {
>     return constantExpression;
>   } {code}
> The return type of the corresponding accept function is more general:
> {code:java}
> @Override public Expression accept(Shuttle shuttle) {
>     return shuttle.visit(this);
>   } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to