[
https://issues.apache.org/jira/browse/CALCITE-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde resolved CALCITE-5823.
----------------------------------
Resolution: Fixed
Fixed in
[8eeab5ea|https://github.com/apache/calcite/commit/8eeab5ea6d94d1d38fd63548d42a082fb1827af6].
Thanks for the PR, [~taoran]! (Nice work. I appreciate how you eliminated
'list == null' checks when the variable was known not to be null.)
> Remove commons-collections dependency from innodb
> -------------------------------------------------
>
> Key: CALCITE-5823
> URL: https://issues.apache.org/jira/browse/CALCITE-5823
> Project: Calcite
> Issue Type: Improvement
> Components: innodb-adapter
> Affects Versions: 1.34.0
> Reporter: Ran Tao
> Assignee: Ran Tao
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.35.0
>
>
> Currently, \{CollectionsUtils} is only used in a few places in the InnoDb
> adapter, and the only methods used are \{isEmpty}} and \{isNotEmpty}.
> The only difference between \{CollectionUtils.isEmpty} and \{list.isEmpty} is
> the behavior if \{list} is null. Modern coding practices would ensure that
> \{list} is not null unless specified in its type.
> So we can safely remove it to avoid using an entire library just for the sake
> of using \{isEmpty}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
