[ 
https://issues.apache.org/jira/browse/CALCITE-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746720#comment-17746720
 ] 

Julian Hyde commented on CALCITE-985:
-------------------------------------

I reviewed, and +1 to merge when you've made my requested cosmetic changes. 
Thank you, [~jiajunbernoulli], for fixing this longstanding issue.

> Validate MERGE
> --------------
>
>                 Key: CALCITE-985
>                 URL: https://issues.apache.org/jira/browse/CALCITE-985
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Jiajun Xie
>            Priority: Major
>              Labels: pull-request-available
>
> Now CALCITE-974 is fixed, we can validate INSERT, UPDATE and DELETE; 
> sql-to-rel conversion also succeeds, although I'm not sure we can execute. 
> MERGE does not yet pass validation.
> I have added SqlToRelConverterTest.testMerge; we need one or two validator 
> fixes to make it pass.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to