[
https://issues.apache.org/jira/browse/CALCITE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748708#comment-17748708
]
Julian Hyde commented on CALCITE-5831:
--------------------------------------
When you create related Jira cases, can you "issue links"? This relates to the
original SOUNDEX function, and also the MySQL SOUNDEX, and also to the
SqlBasicFunction refactoring.
This PR looks good, but I think you should squash in the commit from
CALCITE-5874'; that's a minor (albeit appreciated) refactoring that doesn't
warrant an issue and possibly doesn't need to be a standalone commit.
> Add SOUNDEX function(enabled in Spark library)
> ----------------------------------------------
>
> Key: CALCITE-5831
> URL: https://issues.apache.org/jira/browse/CALCITE-5831
> Project: Calcite
> Issue Type: New Feature
> Components: core
> Affects Versions: 1.34.0
> Reporter: Ran Tao
> Assignee: Ran Tao
> Priority: Major
> Labels: pull-request-available
>
> Hi, devs. I noticed that calcite support soundex for BIG_QUERY, MYSQL,
> POSTGRESQL, ORACLE dialect except Spark. i think we can support it.
> soundex(str) - Returns Soundex code of the string.
> *Examples:*
> > SELECT soundex('Miller');
> M460
> [https://spark.apache.org/docs/latest/api/sql/index.html#soundex]
>
> *Note:* currently soundex for BIG_QUERY, MYSQL, POSTGRESQL, ORACLE dialect
> *throw IllegalArgumentException* when string can't be mapped. However, spark
> not throw exception but return original string.
> [https://github.com/apache/spark/blob/c37d7dec8aa4d703b6dac9b9d60ff25d9d5dc665/common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java#L1595]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
