[ 
https://issues.apache.org/jira/browse/CALCITE-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751737#comment-17751737
 ] 

Julian Hyde commented on CALCITE-5184:
--------------------------------------

The commit message is a bit unclear whether this is a bug of feature. 

Reference.md implies that “LIMIT ALL” is valid? Should it be? Either way, you 
should test it. 

You need some negative tests. If I use ALL in a conformance where it’s not 
supported, I should get an error. 

> In parser, allow "LIMIT start, ALL"
> -----------------------------------
>
>                 Key: CALCITE-5184
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5184
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: hongyu guo
>            Priority: Major
>              Labels: pull-request-available
>
> In parser, allow "LIMIT start, ALL". For example,
> {code:sql}
> SELECT *
> FROM Emp
> ORDER BY sal DESC
> LIMIT 10, ALL
> {code}
> would be equivalent to
> {code:sql}
> SELECT *
> FROM Emp
> ORDER BY sal DESC
> OFFSET 10
> {code}
> No other database supports this syntax, but Calcite supports Postgres' "LIMIT 
> ALL" and MySQL's "LIMIT start, count" so it makes sense to combine them.
> See the original discussion in CALCITE-5086.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to