[
https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17753019#comment-17753019
]
Julian Hyde edited comment on CALCITE-5909 at 8/11/23 11:04 PM:
----------------------------------------------------------------
Hi [~taoran] ,thank you so much for going so deep into this issue,I will
reproduce this problem locally today, and I will communicate with you when I
have an idea.
I think we should understand why testNoUnintendedNewReservedKeywords this
method has a limitation for the child test class not run. I took a look for
code git commits and found [commit
e89784c2|https://github.com/apache/calcite/commits/e89784c270cab5eafeab839bfd3d4cbea816607f]
(part of CALCITE-2457):
{code:java}
[CALCITE-2457] JUnit 4 -> 5: migrate Assume -> Assumptions, drop suites, remove
junit4 from core classpath {code}
Let's see if we could get some information from JIRA above.
Thanks again for your professionalism.
was (Author: shenlang):
Hi [~taoran] ,thank you so much for going so deep into this issue,I will
reproduce this problem locally today, and I will communicate with you when I
have an idea.
I think we should understand why testNoUnintendedNewReservedKeywords this
method has a limitation for the child test class not run.I took a look for code
git commits:
{code:java}
[CALCITE-2457] JUnit 4 -> 5: migrate Assume -> Assumptions, drop suites, remove
junit4 from core classpath {code}
Let's see if we could get some information from JIRA above.
Thanks again for your professionalism.
> Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE
> but passes when run from the command line
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: CALCITE-5909
> URL: https://issues.apache.org/jira/browse/CALCITE-5909
> Project: Calcite
> Issue Type: Bug
> Components: tests
> Reporter: LakeShen
> Priority: Minor
> Labels: pull-request-available
> Attachments: image-2023-08-08-23-32-55-466.png
>
>
> When I run the SqlParserTest,the testNoUnintendedNewReservedKeywords method
> failed,the exception like this:
> {code:java}
> java.lang.AssertionError: The parser has at least one new reserved keyword.
> Are you sure it should be reserved? Difference: {code}
> The picture like this:
> !image-2023-08-08-23-32-55-466.png|width=1543,height=496!
> I could fix this problem.More importantly, why is this method failing, but
> the Calcite pipeline is passing? I think we should look at something we missed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
