[
https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17753423#comment-17753423
]
Julian Hyde commented on CALCITE-5909:
--------------------------------------
Thanks for your detective work, [~taoran]. It sounds very plausible that we
simply stopped running {{SqlParserTest}} directly, and only run its sub-classes.
The reason we do not run this test in sub-classes is that sub-classes will
correspond to a different parser, which may legitimately have a different set
of keywords.
I think the solution is to move the {{testNoUnintendedNewReservedKeywords}}
method from {{SqlParserTest}} to {{CoreParserTest}}. You should still prevent
it from running in sub-classes.
> Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE
> but passes when run from the command line
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: CALCITE-5909
> URL: https://issues.apache.org/jira/browse/CALCITE-5909
> Project: Calcite
> Issue Type: Bug
> Components: tests
> Reporter: LakeShen
> Priority: Minor
> Labels: pull-request-available
> Attachments: image-2023-08-08-23-32-55-466.png
>
>
> When I run the SqlParserTest,the testNoUnintendedNewReservedKeywords method
> failed,the exception like this:
> {code:java}
> java.lang.AssertionError: The parser has at least one new reserved keyword.
> Are you sure it should be reserved? Difference: {code}
> The picture like this:
> !image-2023-08-08-23-32-55-466.png|width=1543,height=496!
> I could fix this problem.More importantly, why is this method failing, but
> the Calcite pipeline is passing? I think we should look at something we missed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
