[
https://issues.apache.org/jira/browse/CALCITE-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754334#comment-17754334
]
Julian Hyde commented on CALCITE-5917:
--------------------------------------
I agree with [~libenchao] that a PR is sufficient for minor changes such as
fixing comments.
[~mbudiu], It's not obvious to me what you consider to be incorrect. Is it that
we are don't 'set ... the field' but instead return a copy (because
{{TimeString}} is immutable)? Or is it that we don't store as many significant
digits as you hoped?
> Comments in TimeString class are incorrect
> ------------------------------------------
>
> Key: CALCITE-5917
> URL: https://issues.apache.org/jira/browse/CALCITE-5917
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.35.0
> Reporter: Mihai Budiu
> Priority: Trivial
>
> Here is an example of an incorrect comment:
> {code:java}
> /** Sets the fraction field of a {@code TimeString} to a given number
> * of milliseconds. Nukes the value set via {@link #withNanos}.
> *
> * <p>For example,
> * {@code new TimeString(1970, 1, 1, 2, 3, 4).withMillis(56)}
> * yields {@code TIME '1970-01-01 02:03:04.056'}. */
> public TimeString withMillis(int millis) {
> {code}
> There are several such comments.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
