[
https://issues.apache.org/jira/browse/CALCITE-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754666#comment-17754666
]
Runkang He commented on CALCITE-5921:
-------------------------------------
[~julianhyde] Thanks for linking the related issue. I have quickly read the two
related issues, and after that, I think this issue may be not directly related
to them. It looks like it was introduced by test fixture framework in
CALCITE-4885.
For more, the basic idea to fix this is to add `tester.checkFails(factory, sap,
expectedError, true)` in SqlOperatorFixture.checkFails when runtime is true.
> SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure
> ---------------------------------------------------------------------------
>
> Key: CALCITE-5921
> URL: https://issues.apache.org/jira/browse/CALCITE-5921
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.35.0
> Reporter: Runkang He
> Assignee: Runkang He
> Priority: Major
>
> SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure.
> See more in [code
> line|https://github.com/apache/calcite/blob/50c3edfc3d6630528ab51fe836bd50df82cc7db8/testkit/src/main/java/org/apache/calcite/test/SqlOperatorFixtureImpl.java#L160].
> When the parameter `runtime` of SqlOperatorFixture.checkFails is true, it
> should execute the query and check runtime failure, but currently it ignores
> this, and only checks the parse and validation failure.
> When fix this, there are 4 failed test cases in CalciteSqlOperatorTest.
> At last, this issue was found when to implement `BIT_GET` function in
> CALCITE-5848.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
