[
https://issues.apache.org/jira/browse/CALCITE-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757686#comment-17757686
]
Julian Hyde edited comment on CALCITE-5931 at 8/22/23 9:45 PM:
---------------------------------------------------------------
PR is looks good, summary is an improvement. Can you also add a test to
{{winagg.iq}}? Executing the query and getting results proves that it works
end-to-end.
Please add commits, as you have been doing, rather than amending. It makes it
easier to review incrementally.
I've tagged fixVersion = 1.36 because this looks close.
was (Author: julianhyde):
PR is loos good, summary is an improvement. Can you also add a test to
{{winagg.iq}}? Executing the query and getting results proves that it works
end-to-end.
Please add commits, as you have been doing, rather than amending. It makes it
easier to review incrementally.
I've tagged fixVersion = 1.36 because this looks close.
> Allow integers like 1.00 in window frame
> ----------------------------------------
>
> Key: CALCITE-5931
> URL: https://issues.apache.org/jira/browse/CALCITE-5931
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.35.0
> Reporter: Claude Brisson
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.36.0
>
>
> When a number of rows is specified for a window, the code checks that the
> provided literal is an integral number.
> But the provided check leaves aside numbers like "1.00" (with a scale of 2,
> but with trailing zeros).
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
