[
https://issues.apache.org/jira/browse/CALCITE-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760573#comment-17760573
]
Julian Hyde commented on CALCITE-5968:
--------------------------------------
There's a possible binary compatibility issue converting a class into an
interface. In my opinion, that risk is minimal.
* In the summary you have 'interface class', which is an oxymoron. Can you fix
it.
* Please improve the javadoc.
* {{class RexExecutorImpl}} should be package-private.
* Is it possible to switch from
{{org.apache.calcite.linq4j.function.Function1}} to
{{java.util.function.Function}}?
* You need at least one test that works at the interface level. Maybe move
{{RexExecutorTest}} into a different package?
> Provide an interface class for RexExecutable to decouple janino runtime
> binding
> -------------------------------------------------------------------------------
>
> Key: CALCITE-5968
> URL: https://issues.apache.org/jira/browse/CALCITE-5968
> Project: Calcite
> Issue Type: Improvement
> Reporter: Wenzhuang Zhu
> Assignee: Wenzhuang Zhu
> Priority: Minor
> Labels: pull-request-available
>
> Provide an interface class for RexExecutable to decouple janino runtime
> binding.
> Users may want to use a different runtime implementation({_}e.g.{_} JNI) .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
