[
https://issues.apache.org/jira/browse/CALCITE-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769230#comment-17769230
]
xinyu liu edited comment on CALCITE-5990 at 9/27/23 4:07 PM:
-------------------------------------------------------------
Hi [~Runking], I am a researcher in field of SE and I am interested in this
regression because it seems to demonstrate a case wherein the existing test
suites are not able to catch the regression when the commit is pushed to the
main branch. Is my understanding correct?
I assume the entire existing test suites get run before each commit is pushed?
Thank you so much for your input!
was (Author: JIRAUSER302376):
Hi, I am interested in this regression. Does this case demonstrates there is
still room of improvement for the existing test suites (so that the bug can be
caught before being pushed to the main branch)?
> Explicit cast to numeric type doesn't check overflow
> ----------------------------------------------------
>
> Key: CALCITE-5990
> URL: https://issues.apache.org/jira/browse/CALCITE-5990
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.35.0
> Reporter: Runkang He
> Assignee: Runkang He
> Priority: Blocker
> Fix For: 1.36.0
>
>
> Explicit cast to numeric type doesn't check overflow, and this issue can be
> reproduced by sqlline:
> {code:sql}
> select cast(empno as tinyint), cast(130 as tinyint) from emps where
> name='Alice'; -- empno is 130
> {code}
> The empno is INT type. The result is:
> {code:sql}
> -126, -126{code}
> I think it should throw exception when overflow.
> At last, this issue was found when to turn on runtime check for
> CalciteSqlOperatorTest in CALCITE-5921.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
