[ 
https://issues.apache.org/jira/browse/CALCITE-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772434#comment-17772434
 ] 

Julian Hyde commented on CALCITE-6034:
--------------------------------------

Adding two parameters to the constructor is not backwards compatible. Add a 
deprecated constructor that forwards, and also consider adding 
withAutoIncrement and withGenerated methods.

> Add `isAutoIncrement` and `isGenerated` arguments to MetaColumn constructor
> ---------------------------------------------------------------------------
>
>                 Key: CALCITE-6034
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6034
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: avatica
>            Reporter: TJ Banghart
>            Assignee: TJ Banghart
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: avatica-1.24.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Adds {{String isAutoincrement}} and {{String isGenerated}} constructor args 
> to  {{MetaColum}} class. Previously these were hardcoded as blank strings in 
> the constructor.
> This is a blocker for CALCITE-5549 as there is no way to set the 
> \{{IS_GENERATED}} value for column metadata.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to