[
https://issues.apache.org/jira/browse/CALCITE-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796416#comment-17796416
]
Julian Hyde commented on CALCITE-6164:
--------------------------------------
This does not belong in the {{example}} module. The purpose of that module is
to teach people to use Calcite using simple examples.
As for whether this test should be added elsewhere. Think about the likelihood
that this test will find a bug, now or in future, that no existing test would
have found. Versus the cost if having the code, maintaining it, and running it
each time the suite runs. There is a cost-benefit analysis.
Is this test checking the correctness of the CSV adapter (file adapter),
rewrite rules, or just general correctness? The answer to that question
determines where is the best place to put it.
> add testPushDownProjectAggregateWithAvg on CsvTest
> --------------------------------------------------
>
> Key: CALCITE-6164
> URL: https://issues.apache.org/jira/browse/CALCITE-6164
> Project: Calcite
> Issue Type: Test
> Components: tests
> Affects Versions: 1.36.0
> Environment: linux+java
> Reporter: Caican Cai
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.37.0
>
>
> The avg operator in the agg operator is actually different from the
> aggregation operators such as max and count, because avg will be split into
> count/avg. I think the avg operator can be formed into a separate test
> I have observed that some other open source projects display avg tests
> separately, e.g: spark sql
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
