[
https://issues.apache.org/jira/browse/CALCITE-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797327#comment-17797327
]
Mihai Budiu commented on CALCITE-208:
-------------------------------------
Moving conversation here from a dev mailing list email thread.
I am copying the initial email and response for context:
{color:#242424}On Fri, Dec 15, 2023 at 12:33 PM Julian Hyde
<[email protected]> wrote:{color}
{color:#242424}>{color}
{color:#242424}> I like your approach to divide the work into moderate-sized
steps. Clear descriptions of those steps help those of us who are overwhelmed
with email (all of us!) track the situation. The first step seems to be
’Support TIMESTAMP and TIME WITH TIME ZONE in the parser’. (I’ve reversed your
current phrasing, ‘Parser does not…’ which makes a missing feature sound like a
bug.){color}
{color:#242424}>{color}
{color:#242424}> After this email thread, let’s move the conversation to
{color}https://issues.apache.org/jira/browse/CALCITE-208{color:#242424}. Jira
is a better medium for long-running conversations.{color}
{color:#242424}>{color}
{color:#242424}> As the type names are so verbose, I recommend that we all
adopt Snowflake’s abbreviations: TIMESTAMP_NTZ, TIMESTAMP_LTZ, TIMESTAMP_TZ,
TIME_NTZ, etc. Be very careful to avoid vendor-specific terms that do not match
the SQL standard (e.g. BigQuery’s TIMESTAMP type is a TIMESTAMP_LTZ, i.e. an
instant; call it “BigQuery TIMESTAMP” or “TIMESTAMP_LTZ” but never
“TIMESTAMP”).{color}
{color:#242424}>{color}
{color:#242424}> I have a feeling that in order to support TIMESTAMP_TZ and
TIME_TZ we will need a notion of the ‘current session time zone’. Can you check
whether we have adequate support for that? If not, it could be a separate
task.{color}
{color:#242424}>{color}
{color:#242424}> Julian{color}
{color:#242424}>{color}
{color:#242424}>{color}
{color:#242424}> On Dec 15, 2023, at 11:04 AM, Mihai Budiu <[email protected]>
wrote:{color}
{color:#242424}>{color}
{color:#242424}> Hello all,{color}
{color:#242424}>{color}
{color:#242424}> There is a feature open for Calcite to support time zones
{color}https://issues.apache.org/jira/browse/CALCITE-208
{color:#242424}> It has been open for 9 years.{color}
{color:#242424}>{color}
{color:#242424}> I have submitted last week a PR which starts to address this
issue: {color}[https://github.com/apache/calcite/pull/3569]
{color:#242424}> I would appreciate reviews on this PR.{color}
{color:#242424}>{color}
{color:#242424}> This will be a lot of work, and I don't think we want it
solved in a monster PR.{color}
{color:#242424}> I plan to do at least some of the follow up work as well once
this is merged.{color}
{color:#242424}>{color}
{color:#242424}> I notice that it's not easy to get reviews on PRs that touch
many parts of the code. I understand, myself I am reluctant to review code that
touches parts I am not familiar with. I will appreciate any advice on making
progress with similar contributions.{color}
> Support TIMESTAMP WITH TIME ZONE data type
> ------------------------------------------
>
> Key: CALCITE-208
> URL: https://issues.apache.org/jira/browse/CALCITE-208
> Project: Calcite
> Issue Type: Improvement
> Reporter: GitHub Import
> Priority: Major
> Labels: github-import
>
> Most databases have a data type that store a date + time component and a time
> zone component. It would be useful for Drill to support this data type.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/julianhyde/optiq/issues/208
> Created by: [mehant|https://github.com/mehant]
> Labels: enhancement,
> Created at: Tue Mar 25 16:57:56 CET 2014
> State: open
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
