[
https://issues.apache.org/jira/browse/CALCITE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797899#comment-17797899
]
Caican Cai edited comment on CALCITE-6165 at 12/17/23 8:14 AM:
---------------------------------------------------------------
[~julianhyde] Hello, I found that there are tests for date_sub and date_add in
SqlOperatorTest, but these two functions are not supported in parser.jj. At
present, the date function may not be aligned before, so I recommend
supplementing the dates in SqlOperatorTest respectively. Function testing
allows developers to better discover differences.
I have added support for datesub and dateadd functions in Parser.jj in this pr.
Maybe I need to change the description information of this jira ticket.
was (Author: JIRAUSER302115):
[~julianhyde] Hello, I found that there are tests for date_sub and date_add in
SqlOperatorTest, but these two functions are not supported in parser.jj. At
present, the date function may not be aligned before, so I recommend
supplementing the dates in SqlOperatorTest respectively. Function testing
allows developers to better discover differences. I have added support for
datesub and dateadd functions in Parser.jj in this pr. Maybe I need to change
the description information of this jira ticket.
> Add datefunctiontest on SqlParserTest
> -------------------------------------
>
> Key: CALCITE-6165
> URL: https://issues.apache.org/jira/browse/CALCITE-6165
> Project: Calcite
> Issue Type: Test
> Components: tests
> Affects Versions: 1.36.0
> Reporter: Caican Cai
> Assignee: Caican Cai
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.37.0
>
>
> In calcite's ParserTest, there is a lack of test for DateFunction. Currently,
> calcite only supports date function from parser.jj:
> date_diff,
> date_trunc.
> It also lacks support for many date functions. For details, you can
> see:[https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html]
> The purpose of adding this datefunctiontest is to tell us which date
> functions are supported and which date functions are not supported
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
