[ 
https://issues.apache.org/jira/browse/CALCITE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798015#comment-17798015
 ] 

Caican Cai commented on CALCITE-6165:
-------------------------------------

[~julianhyde] Thank you for your reply. I did not know how to determine the 
boundary of ordinary functions before, for example, why datediff can be put 
into Parser.jj, are there any rules about this point, which can help me 
correctly understand how to contribute to Calcite community. So should I close 
this jira ticket?

> Add date_sub and date_add functions 
> ------------------------------------
>
>                 Key: CALCITE-6165
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6165
>             Project: Calcite
>          Issue Type: Test
>          Components: tests
>    Affects Versions: 1.36.0
>            Reporter: Caican Cai
>            Assignee: Caican Cai
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.37.0
>
>         Attachments: 2023-12-17 17-04-29屏幕截图-1.png, 2023-12-17 
> 17-04-29屏幕截图.png
>
>
> In calcite's ParserTest, there is a lack of test for DateFunction. Currently, 
> calcite only supports date function from parser.jj:
> date_diff,
> date_trunc.
> It also lacks support for many date functions. For details, you can 
> see:[https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html]
> I supported the two functions date_add and date_sub in Parser.jj, and added 
> relevant tests about date function in SqlParserTest. The purpose of adding 
> this datefunctiontest is to tell us which date functions are supported and 
> which date functions are not supported.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to