[ 
https://issues.apache.org/jira/browse/CALCITE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799478#comment-17799478
 ] 

Ulrich Kramer commented on CALCITE-4188:
----------------------------------------

I also created a PR for this issue: https://github.com/apache/calcite/pull/3562
I had overlooked this ticket here.

The main difference between the two PR is how correlation variable are handled:
- 3562 uses an offset of 10000 to put the correlation variables into the 
DataContext
- 2116 uses an enum to distinguish between correlation variables and dynamic 
variables, which is the more robust way.

> support EnumerableBatchNestedLoopJoin in JdbcToEnumerableConverter implement
> ----------------------------------------------------------------------------
>
>                 Key: CALCITE-4188
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4188
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.25.0
>            Reporter: JIasen Sheng
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> support  EnumerableBatchNestedLoopJoin in JdbcToEnumerableConverter implement 
> function
> ENUMERABLE_BATCH_NESTED_LOOP_JOIN_RULE make correlate RexNode, 
> when implementing,
> [https://github.com/apache/calcite/blob/eab043f4ef43112c16a9f6708e6c53a15b1cfbe0/core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java#L675]
> will throw null Exception



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to