[
https://issues.apache.org/jira/browse/CALCITE-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799895#comment-17799895
]
Tanner Clary commented on CALCITE-6172:
---------------------------------------
[~Sergey Nuyanzin] [~julianhyde] I opened a slightly different approach here:
https://github.com/apache/calcite/pull/3594 .
I like my approach because the onus is no longer on the contributor to manually
list the libraries each operator belongs to. Instead, they just provide a list
of the operators that are aliases of one another and then it iterates through
this operators and each of their respective supported libraries.
I do like that Sergey's uses test parameters though.
If either of you have thoughts or comments feel free to comment on the PR or
here.
> Allow aliased operators to re-use existing tests
> ------------------------------------------------
>
> Key: CALCITE-6172
> URL: https://issues.apache.org/jira/browse/CALCITE-6172
> Project: Calcite
> Issue Type: Improvement
> Reporter: Tanner Clary
> Assignee: Tanner Clary
> Priority: Major
> Labels: pull-request-available
>
> Currently, for operators that have multiple names (potentially across
> multiple libraries), there is no convenient way to re-use tests other than
> just copy and pasting. To avoid redundancy and potential discrepancies, it
> would be helpful if the same set of tests could be used for each alias.
> I'll modify this case once I have some ideas.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
