[
https://issues.apache.org/jira/browse/CALCITE-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807479#comment-17807479
]
Julian Hyde commented on CALCITE-6207:
--------------------------------------
Yes, I think that would be best in this case. I think this PR is just change
for change's sake.
In other cases, my comments in Jira are often stuff like 'Can you improve the
commit message?'. That kind of thing is cosmetic but also important (because it
becomes the release notes and helps us make sense of the project in 5 years),
so it's crucial that the person who presses the 'merge' button makes those
changes.
Let me add that I greatly appreciate what you are doing as a committer, getting
PRs moving. My tendency is to let PRs languish until they are perfect, and you
are a great antidote to that. Please carry on doing what you are doing.
> Improve connection resource in JDBCUtils
> ----------------------------------------
>
> Key: CALCITE-6207
> URL: https://issues.apache.org/jira/browse/CALCITE-6207
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.36.0
> Reporter: xy
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.37.0
>
>
> Improve JDBC connection resource in JDBCUtils: not need multiple judge
> connection whether close
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
