[ 
https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816188#comment-17816188
 ] 

Mihai Budiu commented on CALCITE-6248:
--------------------------------------

[~zstan] it looks like the validation code for dates in the AvaticaUtils is too 
strict.
Using it for all date literals causes several Calcite tests to fail:
https://github.com/apache/calcite-avatica/actions/runs/7848418901/job/21419518616
Dates like 1900-1-1 are rejected.

So the question is: is your validator right, or are the Calcite tests right?

> Illegal dates are accepted by casts
> -----------------------------------
>
>                 Key: CALCITE-6248
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6248
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>    Affects Versions: 1.36.0
>            Reporter: Mihai Budiu
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The following test passes in SqlOperatorTest:
> {code:java}
>   @Test public void testIllegalDate() {
>     final SqlOperatorFixture f = fixture();
>     f.checkScalar("cast('1945-02-32' as DATE)",
>         "1945-03-04", "DATE NOT NULL");
>   }
> {code}
> There is no February 32, I suspect that this expression should produce an 
> error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to