[ 
https://issues.apache.org/jira/browse/CALCITE-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tanner Clary updated CALCITE-6290:
----------------------------------
    Description: 
The [BigQuery 
docs|https://cloud.google.com/bigquery/docs/reference/standard-sql/mathematical_functions#trunc]
 state that when the TRUNC function is provided an integer argument, it should 
return a double. However, we currently have the return type set to 
{{ARG0_NULLABLE}}. We should probably adjust this to 
{{ARG0_EXCEPT_INTEGER_NULLABLE}} similar to CALCITE-5747

This change also adjusts the NULLABILITY for CEIL_BIG_QUERY and FLOOR_BIG_QUERY 
as I incorrectly set these with I implemented CALCITE-5747

  was:The [BigQuery 
docs|https://cloud.google.com/bigquery/docs/reference/standard-sql/mathematical_functions#trunc]
 state that when the TRUNC function is provided an integer argument, it should 
return a double. However, we currently have the return type set to 
{{ARG0_NULLABLE}}. We should probably adjust this to 
{{ARG0_EXCEPT_INTEGER_NULLABLE}} similar to CALCITE-5747


> Incorrect return type for BigQuery TRUNC
> ----------------------------------------
>
>                 Key: CALCITE-6290
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6290
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Tanner Clary
>            Assignee: Tanner Clary
>            Priority: Major
>              Labels: pull-request-available
>
> The [BigQuery 
> docs|https://cloud.google.com/bigquery/docs/reference/standard-sql/mathematical_functions#trunc]
>  state that when the TRUNC function is provided an integer argument, it 
> should return a double. However, we currently have the return type set to 
> {{ARG0_NULLABLE}}. We should probably adjust this to 
> {{ARG0_EXCEPT_INTEGER_NULLABLE}} similar to CALCITE-5747
> This change also adjusts the NULLABILITY for CEIL_BIG_QUERY and 
> FLOOR_BIG_QUERY as I incorrectly set these with I implemented CALCITE-5747



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to