[
https://issues.apache.org/jira/browse/CALCITE-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mihai Budiu resolved CALCITE-2565.
----------------------------------
Resolution: Invalid
This issue seems to no longer be valid.
> Suspicious code in org.apache.calcite.rex.RexBuilder#makeCastIntervalToExact
> ----------------------------------------------------------------------------
>
> Key: CALCITE-2565
> URL: https://issues.apache.org/jira/browse/CALCITE-2565
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Priority: Major
>
> {code:java} final int scale = 0;
> BigDecimal divider = endUnit.multiplier.scaleByPowerOfTen(-scale);
> RexNode value = multiplyDivide(decodeIntervalOrDecimal(exp),
> multiplier, divider);
> if (scale > 0) { // <-- THIS IS ALWAYS FALSE
> RelDataType decimalType =
> getTypeFactory().createSqlType(
> SqlTypeName.DECIMAL,
> scale + exp.getType().getPrecision(),
> scale);
> value = encodeIntervalOrDecimal(value, decimalType, false);
> }
> {code}
> Is if(scale>0) a dead code?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
