[ 
https://issues.apache.org/jira/browse/CALCITE-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856879#comment-17856879
 ] 

Julian Hyde commented on CALCITE-6444:
--------------------------------------

Can you begin the description with the feature you propose to add.

"Redshift" has lower-case "s". Can you change summary accordingly. Probably the 
summary should say "Amazon Redshift".

I'm not too concerned about Babel. As a parser that spans multiple inconsistent 
dialects, there are bound to be cracks.

Is it reasonable to assume that every function in the Postgres library will 
also appear in the Redshift library? Or perhaps 95%? If so, can you suggest how 
to achieve this painlessly.

> Add a RedShift SqlLibrary
> -------------------------
>
>                 Key: CALCITE-6444
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6444
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.34.0
>            Reporter: Norman Jordan
>            Assignee: Norman Jordan
>            Priority: Major
>
> The Babel tests assume that RedShift is a union of the Oracle and PostgreSQL 
> libraries. This is not accurate. There are functions such as *INCR* that are 
> supported by Oracle and not by RedShift. Problems will also occur when Oracle 
> and Postgres both support a function of the same name that needs different 
> implementations.
> [https://github.com/apache/calcite/blob/main/babel/src/test/java/org/apache/calcite/test/BabelQuidemTest.java#L110]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to