[ 
https://issues.apache.org/jira/browse/CALCITE-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Grein updated CALCITE-6490:
-------------------------------
    Description: After making some improvements to the OVERLAY operator docs in 
[[https://github.com/apache/calcite/pull/3877|link]|https://github.com/apache/calcite/pull/3877]
 I've noticed that there are no tests for SqlFunctions#overlay in 
SqlFunctionsTest. As checkString in SqlOperatorTest doesn't check the actual 
value against the expected result (at least that's how I understood it) I 
thought it's even more important to add tests for the OVERLAY operator in 
SqlFunctionsTest.  (was: After making some improvements to the OVERLAY operator 
docs in https://github.com/apache/calcite/pull/3877 I've noticed that there are 
no tests for SqlFunctions#overlay in SqlFunctionsTest. As checkString in 
SqlOperatorTest doesn't check the actual value against the expected result (at 
least that's how I understood it) I thought it's even more important to add 
tests for the OVERLAY operator in SqlFunctionsTest.)

> Missing tests for SqlFunctions#overlay
> --------------------------------------
>
>                 Key: CALCITE-6490
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6490
>             Project: Calcite
>          Issue Type: Improvement
>          Components: tests
>    Affects Versions: 1.37.0
>            Reporter: Tim Grein
>            Assignee: Tim Grein
>            Priority: Minor
>             Fix For: 1.38.0
>
>
> After making some improvements to the OVERLAY operator docs in 
> [[https://github.com/apache/calcite/pull/3877|link]|https://github.com/apache/calcite/pull/3877]
>  I've noticed that there are no tests for SqlFunctions#overlay in 
> SqlFunctionsTest. As checkString in SqlOperatorTest doesn't check the actual 
> value against the expected result (at least that's how I understood it) I 
> thought it's even more important to add tests for the OVERLAY operator in 
> SqlFunctionsTest.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to