[ 
https://issues.apache.org/jira/browse/CALCITE-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868058#comment-17868058
 ] 

Alessandro Solimando commented on CALCITE-6489:
-----------------------------------------------

Supporting TINYINT and SMALLINT is an improvement, but I don't think we should 
split every individual type to a single PR, it's not that hard to add support 
for all types within the same PR (see CALCITE-3465 as an example), as discussed 
in CALCITE-6292.

I also don't see the reason on having a separate ticket for creating the 
dataset and one for adding type support, for me they should belong to the same 
ticket and PR, possibly multiple commits to make the review easier, but that's 
it.

 

 

> Add more data types to the Arrow test set
> -----------------------------------------
>
>                 Key: CALCITE-6489
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6489
>             Project: Calcite
>          Issue Type: Sub-task
>            Reporter: Caican Cai
>            Assignee: Caican Cai
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, the Arrow test set only has basic data types, such as int, long, 
> etc., but does not have smallInt, tinyint, etc.
> It is possible to improve the Arrow test set



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to