[
https://issues.apache.org/jira/browse/CALCITE-6497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Solimando resolved CALCITE-6497.
-------------------------------------------
Resolution: Fixed
Fixed via
[{{15a5360}}|https://github.com/apache/calcite/commit/15a53603ef8332cab50564f6b3b5d434a8238d7a],
thanks [~timgrein] for the contribution and [~nobigo] and [~caicancai] for the
review!
> Use helper setup method throughout whole ElasticsearchAdapterTest
> -----------------------------------------------------------------
>
> Key: CALCITE-6497
> URL: https://issues.apache.org/jira/browse/CALCITE-6497
> Project: Calcite
> Issue Type: Improvement
> Components: elasticsearch-adapter, tests
> Affects Versions: 1.37.0
> Reporter: Tim Grein
> Assignee: Tim Grein
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.38.0
>
>
> There's a helper method `calciteAssert` inside the
> `ElasticsearchAdapterTest`, which is responsible for setting up a connection
> to Elasticsearch. This helper method is not used throughout the test class
> consistently, which leads to code duplication and some manual setup code. We
> should use the helper method to keep things consistent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
