[
https://issues.apache.org/jira/browse/CALCITE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868997#comment-17868997
]
Mihai Budiu commented on CALCITE-3522:
--------------------------------------
I was waiting for an approving review for the PR
https://github.com/apache/calcite/pull/3589
Let me address the two comments from the last review, maybe this will be enough.
If you can help with reviewing it may also help. For example, you could test
whether this fix addresses your problem.
> Sql validator limits decimal literals to 64 bits
> ------------------------------------------------
>
> Key: CALCITE-3522
> URL: https://issues.apache.org/jira/browse/CALCITE-3522
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.18.0, 1.36.0
> Reporter: Changbo Shu
> Assignee: Mihai Budiu
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.38.0
>
> Attachments: code.png
>
>
> [https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L2983]
> for example:
> create table tbl(f1 double),
> f1 stores a double's max value. (1.7976931348623157E308)
> long max value isĀ 9223372036854775807.
> select * from table where f1=value, if value is greater than long max,
> sqlvalidator will throw out of range exception.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)