[ 
https://issues.apache.org/jira/browse/CALCITE-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870774#comment-17870774
 ] 

Julian Hyde commented on CALCITE-6513:
--------------------------------------

This bug makes sense, and so does the fix. Let's be sure to get this in before 
1.38. But a few things:
 * Link to CALCITE-3774, so that people can find this case from the other end.
 * The configuration changes, plumbing in a different {{RelBuilder}}, are 
extremely complex. They should be a separate commit. Also I would like to see 
justification for why they are necessary.
 * Can you include a simple example in the description where the result of 
applying the rule is more complex than the inputs. (It doesn't need to give 
OOM, but does need to let people understand the problem.)


> FilterProjectTransposeRule may cause OOM when Project expressions are complex
> -----------------------------------------------------------------------------
>
>                 Key: CALCITE-6513
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6513
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>
> CALCITE-3774 addresses preventing merging projects when the resulting 
> expressions in the merged project are too complex and lead to slow 
> compilation or out of memory.
> However, when there is a {{Filter}} on top of the {{Projects}} with a 
> predicate referencing the complex expressions {{FilterProjectTransposeRule}} 
> tries to push down the {{Filter}} below the bottom {{Project}} merging the 
> expressions and causing OOM.
> The issue was initially reproduced using Hive with the Hive version of 
> {{FilterProjectTransposeRule}}. See: HIVE-28264
> Calcite is also affected: 
> [https://github.com/kasakrisz/calcite/commit/b35a02f368624a9c4768f348cd072a95ed6de3e1]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to