[
https://issues.apache.org/jira/browse/CALCITE-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876094#comment-17876094
]
Julian Hyde commented on CALCITE-6534:
--------------------------------------
[~mbudiu], Thank you for merging PRs that are ready, but please check jira
before you do so. I identified a problem with the commit message that has not
been fixed, and now cannot be fixed without a force-push. If you don't check
jira, my efforts reviewing cases are wasted.
> Adjust type when pulling up Calc in JoinUnifyRule
> -------------------------------------------------
>
> Key: CALCITE-6534
> URL: https://issues.apache.org/jira/browse/CALCITE-6534
> Project: Calcite
> Issue Type: Improvement
> Reporter: suibianwanwan
> Assignee: suibianwanwan
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.38.0
>
>
> In JoinOnLeftCalcUnifyRule, JoinOnRIghtCalcUnifyRule, JoinOnCalcUnifyRule,
> calcite tries to pull up the calc operator to make Query equivalent to target
> . In CALCITE-6501, for the case where the assert is due to a difference in
> nullablity, we do an early intercept and return null. This will result in
> some cases that can be rewritten not being able to be rewritten.
> Therefore, We can adjust the nullability of the type if this rewrite
> maintains semantics. if RexNode satisfies null-if-null, we will adjust the
> nullability, if not, we should reject this rewrite regardless of the
> nullablility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
