[
https://issues.apache.org/jira/browse/CALCITE-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883424#comment-17883424
]
James Duong commented on CALCITE-6465:
--------------------------------------
I've managed to integrate the Flink code splitter in when writing out
MethodDeclarations now. Tests are green in CI in the PR:
[https://github.com/apache/calcite/pull/3901]
I've added a CalciteSystemProperty for enabling this functionality. It is off
by default. Unit tests do enable method splitting by default. Note that
AbstractNode.toString() always has method splitting on – it can't access a
CalciteSystemProperty since AbstractNode is in linq4j, CalciteSystemProperty is
in calcite-core, and calcite-core depends on linq4j. I wonder if there's a
better way of making this configurable.
I think what's left in this PR is to add a 4K-long method that will throw the
method-too-long error with method-splitting disabled and correctly compile when
method-splitting is enabled.
> Rework code generator
> ---------------------
>
> Key: CALCITE-6465
> URL: https://issues.apache.org/jira/browse/CALCITE-6465
> Project: Calcite
> Issue Type: New Feature
> Components: core
> Reporter: James Duong
> Assignee: James Duong
> Priority: Major
> Labels: pull-request-available
>
> Holistically replace the (or provide a separate optional) code generator to
> reduce issues such as CALCITE-3094 .
> One suggestion in the comments for CALCITE-3094 has been to use the [code
> generator from
> Flink.|https://nightlies.apache.org/flink/flink-docs-release-1.3/api/java/org/apache/flink/table/codegen/CodeGenerator.html]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
