[
https://issues.apache.org/jira/browse/CALCITE-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884616#comment-17884616
]
Istvan Toth commented on CALCITE-6590:
--------------------------------------
I have changed my mind.
I think that using a reflection based solution is better.
I originally thought (and said) that we only use the deprecated methods in the
Hadoop specific code, but I was wrong, we run the whole HTTP server in a
doAS(){} block.
We can lift it directly from Jetty 12:
https://github.com/jetty/jetty.project/blob/jetty-12.1.x/jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/security/SecurityUtils.java
> Run tests with java.security.manager=allow on JDK23+ in Avatica
> ---------------------------------------------------------------
>
> Key: CALCITE-6590
> URL: https://issues.apache.org/jira/browse/CALCITE-6590
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Istvan Toth
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.26.0
>
>
> Remove use of Java SecurityManager in Avatica.
> Running Avatica on JDK 23 (or JRE 23) we get the following runtime errors:
> {noformat}
> Caused by: java.lang.UnsupportedOperationException: getSubject is supported
> only if a security manager is allowed at
> java.base/javax.security.auth.Subject.getSubject(Subject.java:347) at
> org.apache.calcite.avatica.server.SubjectPreservingPrivilegedThreadFactory.newThread(SubjectPreservingPrivilegedThreadFactory.java:43)
> {noformat}
> We were warned - the {{getSubject}} method has been deprecated since JDK 18.
> The deprecation did not cause a build failure, due to CALCITE-5136.
> HADOOP-19212 is an issue with the same underlying cause.
> The message "getSubject is supported only if a security manager is allowed"
> implies that another solution would be to enable a security manager
> (including during tests, and when Avatica is used in Calcite's tests). Should
> we consider that? If so, please change the case summary.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
