[
https://issues.apache.org/jira/browse/CALCITE-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884786#comment-17884786
]
Julian Hyde commented on CALCITE-6585:
--------------------------------------
I reviewed the PR, and it looks good.
I had hoped that there would be more commonality with \{{class FormatElement}},
which was introduced in CALCITE-5357 for the BigQuery equivalents of TO_CHAR
and also for the standard \{{CAST(... FORMAT)}} operator in CALCITE-2980.
> In the Postgres TO_CHAR function, improve caching
> -------------------------------------------------
>
> Key: CALCITE-6585
> URL: https://issues.apache.org/jira/browse/CALCITE-6585
> Project: Calcite
> Issue Type: Improvement
> Reporter: Julian Hyde
> Assignee: Norman Jordan
> Priority: Major
> Labels: pull-request-available
>
> In the Postgres TO_CHAR function (and similar functions added in
> CALCITE-6358), cache the formatter using the same technique used in
> CALCITE-5914.
> Also pass the {{DataContext}} into the constructor of {{class
> DataFormatFunction}}, so that it does not need to be passed to each call to
> {{toCharPg}}.
> In {{DateFormatFunction}} obsolete static field {{LOCAL_ZONE}} and instead
> populate a non-static field {{zoneId}} from the {{DataContext}} constructor
> parameter.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
