[
https://issues.apache.org/jira/browse/CALCITE-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde updated CALCITE-6598:
---------------------------------
Description:
In {{{}interface RelDataTypeSystem{}}}, deprecate {{getMaxNumericScale()}} in
favor of {{getMaxScale(SqlTypeName)}} and {{getMaxNumericPrecision()}} in favor
of {{{}getMaxPRecision(SqlTypeName){}}}.
This will make them consistent with {{getMinScale(SqlTypeName)}} and
{{getMinPrecision(SqlTypeName)}} (both added in CALCITE-6560).
For each pair of methods (one with {{SqlTypeName}} and one without), if we
allow people to choose which to override, things will become too complicated.
So, in release 1.39 we will make {{getMaxNumericScale()}} and
{{getMaxNumericPrecision()}} methods final (in addition to being deprecated as
of release 1.38). People should only override {{getMaxScale(SqlTypeName)}} and
{{{}getMaxPrecision(SqlTypeName){}}}.
This will be a *breaking change* in 1.39 -- projects that have overridden these
methods will be broken – but at least we will have given them one release
warning.
was:
In {{{}interface RelDataTypeSystem{}}}, deprecate {{getMaxNumericScale()}} in
favor of {{getMaxScale(SqlTypeName)}} and {{getMaxNumericPrecision()}} in favor
of {{{}getMaxPRecision(SqlTypeName){}}}.
This will make them consistent with {{getMinScale(SqlTypeName)}} and
{{getMinPrecision(SqlTypeName)}} (both added in CALCITE-6560).
For each pair of methods (one with {{SqlTypeName}} and one without), if we
allow people to choose which to override, things will become too complicated.
So, in release 1.39 we will make {{getMaxNumericScale()}} and
{{getMaxNumericPrecision()}} methods final. This will be a *breaking change* -
people who have overridden these methods will be broken.
> In RelDataTypeSystem, deprecate methods getMaxNumericScale and
> getMaxNumericPrecision
> -------------------------------------------------------------------------------------
>
> Key: CALCITE-6598
> URL: https://issues.apache.org/jira/browse/CALCITE-6598
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Priority: Major
>
> In {{{}interface RelDataTypeSystem{}}}, deprecate {{getMaxNumericScale()}} in
> favor of {{getMaxScale(SqlTypeName)}} and {{getMaxNumericPrecision()}} in
> favor of {{{}getMaxPRecision(SqlTypeName){}}}.
> This will make them consistent with {{getMinScale(SqlTypeName)}} and
> {{getMinPrecision(SqlTypeName)}} (both added in CALCITE-6560).
> For each pair of methods (one with {{SqlTypeName}} and one without), if we
> allow people to choose which to override, things will become too complicated.
> So, in release 1.39 we will make {{getMaxNumericScale()}} and
> {{getMaxNumericPrecision()}} methods final (in addition to being deprecated
> as of release 1.38). People should only override {{getMaxScale(SqlTypeName)}}
> and {{{}getMaxPrecision(SqlTypeName){}}}.
> This will be a *breaking change* in 1.39 -- projects that have overridden
> these methods will be broken – but at least we will have given them one
> release warning.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
