[ 
https://issues.apache.org/jira/browse/CALCITE-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885122#comment-17885122
 ] 

suibianwanwan commented on CALCITE-6586:
----------------------------------------

I try to add more tests, but sometimes I can't get the expected results because 
of the cost selection and calculated. For example, pulling up constants and 
pruning constant columns in Project do not reduce the cost in the current cost 
model.
And since the changes in this PR are beyond the scope of the original JIRA, 
I'll create a new JIRA as a prerequisite to this PR and convert it to a draft 
for the time being.

> Some Rules not firing due to RelMdPredicates returning null in VolcanoPlanner
> -----------------------------------------------------------------------------
>
>                 Key: CALCITE-6586
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6586
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: suibianwanwan
>            Priority: Major
>              Labels: pull-request-available
>
> Because getPredicates(RelSubset r, RelMetadataQuery mq) returns null by 
> default, some rules will not work in volcanoPlanner. Such as 
> SortRemoveConstantKeysRule, UnionPullUpConstantsRule, 
> ExchangeRemoveConstantKeysRule, AggregateJoinTransposeRule, 
> ReduceExpressionsRule, etc. 
> {code:java}
> public RelOptPredicateList getPredicates(RelSubset r,
>     RelMetadataQuery mq) {
>   if (!Bug.CALCITE_1048_FIXED) {
>     return RelOptPredicateList.EMPTY;
>   } 
> }{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to