[ 
https://issues.apache.org/jira/browse/CALCITE-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886933#comment-17886933
 ] 

Stamatis Zampetakis commented on CALCITE-6609:
----------------------------------------------

The suppressions are only relevant when the 
[https://github.com/google/guava-beta-checker] (ErrorProne plugin) is running. 
As long as we don't run ErrorProne with old Guava versions there is no problem. 

I confirm that in CI we run ErrorProne only against the latest Guava version.

Btw, I don't find the guava-beta-checker a must-have for Calcite since it's 
very specific to Guava and its BetaApis but that's another topic.

> Remove redundant warning suppression for Guava's Beta and Unstable APIs
> -----------------------------------------------------------------------
>
>                 Key: CALCITE-6609
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6609
>             Project: Calcite
>          Issue Type: Task
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Trivial
>
> The source code has a bunch of warning suppression for Beta and Unstable APIs 
> that were originally added to by-bass [errorprone 
> errors|https://github.com/google/guava-beta-checker] from the use of Guava's 
> Beta APIs.
> {noformat}
> @SuppressWarnings({"BetaApi", "UnstableApiUsage"}){noformat}
> The suppression is no longer necessary since in the latest Guava versions the 
> APIs that we use are stable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to